Jump to content
LaunchBox Community Forums

maikeru1986

Members
  • Posts

    45
  • Joined

  • Last visited

Posts posted by maikeru1986

  1. On 7/19/2022 at 5:04 PM, JoJoJuJu59 said:

    Heh, just tried it now with the same version that was giving me trouble on the same build of LB and it works fine.  Must have been the older Windows build I was using or something.  Love the new added features, btw, and it runs much smoother than the older version I was using where it would freeze up my LB until the video was downloaded. Great job on this plugin. Thanks.

    Cool, glad to hear it's working for you now.

    btw, unless it's very old even a previous version shouldn't freeze up launchbox as it should be asyncronous, that's interesting. did it freeze up your computer as well?

  2. On 5/15/2022 at 5:05 PM, JoJoJuJu59 said:

    This didn't work for me (v0.47).  I'm on v12.11 of LB.  Putting the new builds of Vidsnap Scraper into my Plugins folder completely crashes/hangs Launchbox at the splash-screen so I had to go back to an old version of Vidsnap Scraper that was in an earlier beta form but with missing features.  Would love to try the newer builds with added features because it's one of the more useful plugins for me and I appreciate the author's work.

    Sorry only seeing this now. I'll have a look.

    Edit:

    I think i'll need some more info, not sure what, but it seems to be working on my end with LB v12.11 and Vidsnap Scraper v0.47 (I downloaded it from here again), see below. Plugins can definitely make LB hang though, whats the latest version that worked for you?

    Screenshot 2022-07-19 122916.jpg

    Screenshot 2022-07-19 122934.jpg

    Screenshot 2022-07-19 123013.jpg

    Screenshot 2022-07-19 123041.jpg

  3. On 12/13/2021 at 2:29 AM, darreldearth said:

    Awesome! only thing that could make it better would be to add an option to paste in a specific URL to a chosen Youtube video

    Also, seems that the plugin downloads the same video regardless of what keywords i use. Seems like its stuck on using the Trailer keyword. Only way i can get it to download something different is to lower the maximum length from 600 to something like 200

    1) I had a look at the above issue, but I can't seem to completely replicate it and also I'm thinking that I wouldn't be able to fix it. 

    It could be the way ytsearch function works in yt-dlp,but it's not as well documented as the other functions and I'm not sure which parameters to change. However, it could possibly be youtube itself giving you the same video regardless of search terms (I don't know how youtube algorythms work)???

    I did change some parameters and have uploaded a new version, but I doubt it changed anything at all.

    Below are some screenshots:

    651002020_Screenshot2022-01-10094542.thumb.png.5f63b703cbfdfa57d72100d480670b02.png560863433_Screenshot2022-01-10094648.thumb.png.af997c0a108fb8a405b9337aefdbb645.png

    1148348836_Screenshot2022-01-10101625.thumb.png.3307585d31b78e196c85650848958a33.png1431966834_Screenshot2022-01-10101656.thumb.png.e5869694f4ef7078f4cb04bb01afd279.png

    525725704_Screenshot2022-01-10101904.thumb.png.04579de105950294e8957a4ab76be28d.png86001822_Screenshot2022-01-10101928.thumb.png.c75d6d12516d5d1a95ce5ec37e176425.png

     

    2) I thought about adding a custom URL link, but would then only be for 1 video at a time, hence I do suggest just pasting in the video URL in the edit menu of the game before running the plugin. i'll add it to the todo list and have a look again when I get some free time.

     

    Sorry I wasn't much help on this one.

  4. On 12/13/2021 at 2:29 AM, darreldearth said:

    Awesome! only thing that could make it better would be to add an option to paste in a specific URL to a chosen Youtube video

    Also, seems that the plugin downloads the same video regardless of what keywords i use. Seems like its stuck on using the Trailer keyword. Only way i can get it to download something different is to lower the maximum length from 600 to something like 200

    That's interesting, I'll have a look into the trailer thing when I get a chance and get back to you . with regards to the link, that should be easy to do but not what I was going for with the plugin as if you are already going for a specific link manually then it might be easier just to use youtube-dl or yt-dlp to do that? alternatively, you could paste in the video url textbox before running the plugin.

    image.thumb.png.7b3c2b2bea0bff0d4b82ecfed6705c62.png

    nevertheless, I'll see what I can do.

    • Like 1
  5. 14 hours ago, OdinsPlayground said:

    Just tested and it does the job! Don't mind it taking a bit longer to convert, as long as it's working. 

    Bug / inconvenience: Getting 50++ pop-ups I have to close individually after parsing.  It's every game it doesn't find.  I think the list given at the end of which games didn't download is enough. 

    Oh I'll take that out no problem. It was for testing purposes mainly. 

  6. On 7/20/2021 at 7:27 PM, OdinsPlayground said:

    @maikeru1986 No worries regarding the "request", more of an "This would be awesome in the future"-idea, but obviously something that would require a lot of work. Not expecting anything. Definitely fixing the timeframe bug would be the biggest actual request, so it's in a workable state. 

    Would the AviDemux work to fix it as C-Beats mentioned? Using that codec instead? I see they have dev tools and it's open source. Thanks for the suggestions @C-Beats, been looking for a Windows app to do that. 

    minor update as I said I would earlier. Tested it on 55 games, downloaded and trimmed 52/55, but that's not necessarily the trimming (I actually think it just didn't find those videos).

    Trimming takes much longer though as it has to re-encode the video.

     

    • Like 1
  7. Yes, @C-Beats is right. The problem is I opted to copy the videos instead of re-encode them. I did this because copying is much quicker (tbh I didn't test re-encoding to see the how long it would take). I'll do this as a quick fix in the mean time (at least I think it should work).

    I'll also check out AviDemux. However what I would like ultimately is to only download a portion of a video.

    • Like 1
  8. Yeah there's definitely some bugs I need to work out or at least some learning to do with FFmpeg.

    • I think the dead seconds is the part between the closest previous keyframe and the cut position. FFmpeg supposedly uses an edit list to instruct the player to start from the cut position, but unfortunately not all players support edit lists.
    • I also noticed it getting stuck on some videos sometimes, which hasn't heppened before, but sometimes that same video would complete in another run. I didn't change anything else relating to the downloading part  however I did notice once FFmpeg is in the same folder as youtube-dl it allows downloading of higher quality/different formats.

    I'll look into these issues as soon as I have a bit more free time, which unfortunately is hard to come by at the moment.

    With regards to previewing videos etc. I doubt that would be anytime soon, or at all, sorry. Besides being a significant developement to the current, theres also the issue of the plugin potentially "scraping" 100's of videos which could lead to issues with google/youtube putting up capchas or IP bans... who knows. I guess I should put a disclaimer in the original post. But who knows, I might look into it one day as that would be kinda cool. 

  9. On 1/19/2021 at 1:29 AM, OdinsPlayground said:

    I've been looking for something like this. But any chance you could apply a video time crop? For example: the plugin / search might find a 5min video, but crops it to 30 sec if the settings is set to crop to that. Would make it a lot more useful, instead of downloading lengthy gameplay videos. As well as higher compatibility in finding videos that can be used. 

    I've put together something that kinda works as a start. please try v0.3.0:

     

    • Like 1
  10. 3 hours ago, JoJoJuJu59 said:

    The eagle has landed!  It works with 11.4 ? Kudos to both you & @JoeViking245  It's a shame that there isn't a YT-like service catering strictly to older DOS era games since I only get about 20% success rate when scraping for MS-DOS games (was intending to use it with eXoDOS to get those missing video snaps) 

    No problem. Yeah, I intend to implement "search terms" input and some things to increase success rate, maybe have more results and pick the best match (honestly not sure), but unfortunately depends on what YT has. I did intend it for Modern Windows titles as i don't think emu-movies has many (see below).

    3 hours ago, JoJoJuJu59 said:

     I won't use emu movies anymore since they renewed my subscription without authorization so this is a handy little utility  Thx, guys ?

     Yeah, I'm kinda banned from emu-movies but that's completely my fault (created a second account cos I forgot my first, then remembered my first and used both... long story).

    However, I think a service/database like that (LB also) takes time and effort and they probably deserve compensation for it, so it's always good to support where we can.

    Vidsnap_Scraper will remain free though?

  11. 47 minutes ago, JoeViking245 said:

    No.  In fact attempting that may actually cause more problems than do good.  

    The issue here was the plugin looks for Unbroken.Launchbox.Plugins.dll [v11.8 vs v11.4].  Rightfully so, as that's the current release.  You might be able to compile it with reference to an older Unbroken.Launchbox.Plugins.dll version (say, 11.4).  As I think about it, I haven't updated my plugins in a while and I think they still work.  

    I think the answer it to design for [on] the latest stable release and users be updated to the latest stable release.

    Ah I see. Was just thinking of the people who bought an older version. I guess if there are many requests for it (doubtful) I might look into it, but otherwise I think you're absolutely right.

    • Like 1
  12. Ok so you don't even get the icon/item in the right-click menu? and you do have other working plugins, and there are no errors during LB startup.

    Thats right before anything even really starts so not sure what that could be but I will try to look into it for you but.

    you're on windows 10? which game are you testing out? platform? Sorry these are all shots in the dark.

    Perhaps someone else here could shed some light.

     

  13. 11 hours ago, JoJoJuJu59 said:

    Doesn't work for me.  I'm using Launchbox 11.4 (premium).  I've extracted both Vidsnap_Scraper.dll and youtube-dl.exe into the folder "Vidsnap Scraper" in \plugins and no joy.

    Hi there, sorry to hear it doesn't work for you. Could you try changing the folder name to "Vidsnap_Scraper" (with the underscore) and trying again? i changed this at some stage and forgot to change the writup, apologies.

    11 hours ago, JoJoJuJu59 said:

    The latest youtube scraper (0.1.9.1?) doesn't work for me either but an old beta does.  However, the Steam Scraper from this forum works perfectly.  Any ideas?

    Both of these are made by @srxz and maybe he could shed more light.

    I think Youtube Scraper needs an update or something, I think it uses YouTubeSearch library which unfortunately is kinda defunct due to Youtube changing things all the time. Steam Scraper works well for me too.

  14. 4 minutes ago, C-Beats said:

    The way @JoeViking245 posted would work as well but you need to get the parent of that location (or should) because any calls like that will direct you to the \\LaunchBox\Core\ folder and you want to start the Path.Combine at the \\LaunchBox\ level.

    Interesting, I've tested it out and it seems to give me the path of where the dll is.  i.e. C:\Users\<Username>\LaunchBox\Plugins\Vidsnap_Scraper

    It seemed to me that "GetExecutingAssembly()' referred to the dll.

    Thanks, i'll have a look into it.

  15. 5 minutes ago, JoeViking245 said:

    In VSScraper.cs, add

    
    private string pluginPath = Path.GetDirectoryName(System.Reflection.Assembly.GetExecutingAssembly().Location) + "\\";

    In the (4) "Process youtube_dl = new Process();" sections, change:

    
    // youtube_dl.StartInfo.FileName = $@"{GetSystemDirectory()}\youtube-dl.exe";
    // TO
    youtube_dl.StartInfo.FileName = pluginPath + "youtube-dl.exe";

    And place "youtube-dl.exe" inside the ../Plugins/Vidsnap Scraper/  folder.  Then there's no issue with the System32 or WoW-whatever folder issues. ;) 

    Well, it at least worked the one time I tried. ?

    I've just tried out @C-beats recommendation and it works fine.

    I'll try yours too  (will just have to figure out how it works - for learing purposes).

    Thanks!

  16. 1 hour ago, C-Beats said:

    Should be able to do something similar to the below to get your plugin folder. Replace "PluginName" with the name of your plugin folder.

    
    Path.Combine(Directory.GetParent(Directory.GetCurrentDirectory()).FullName, "Plugins", "PluginName")

     

    Great thanks.

    would this below also work or is it somehow bad practice or something? just curious

    Path.Combine(Directory.GetCurrentDirectory(), "Plugins", "Plugin_Name")

    should give ~Launchbox\Plugins\PluginName no?

    Actually realised i've used this previously in another app, such a dumbass trying to overcomplicate things.

    Thanks!

×
×
  • Create New...