reproducible crash on add saved filters dialog

[haniobaid]

- Noticed it on LB 5.5 premium - OS is Windows 10 pro 64 bit with Nvidia graphics - issue reproduced occasionally when following steps below - Steps to reproduce: 1. open custom filters screen 2. click plus icon to bring up the (add saved filter) dialog 4. Click the (down arrow icon) to the right of 3 or 4 different dropdowns (twice each, to open and close) - Error message: Launchbox has stopped working. A problem casued the program to stop working correctly. Windows will close the program and notify you if a solution is available. (options are debug or close program) If you click debug,, the error is: An unhandled Microsoft .NET Framework exception occured in Launchgbox.exe [33336]. Note: If I just click really fast on the arrow of a dropdown field, the issue happens every time from 2 or 3 clicks, otherwise when I reproduce in normal use, it can happen on opening 2nd or 3rd or 4th dropdown, or not at all Windows log, say access violation. Not sure if relevant but I am runing LB as administrator. From Windows Log A: Application: LaunchBox.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.AccessViolationException Stack: at System.Windows.Forms.UnsafeNativeMethods.CallWindowProc(IntPtr, IntPtr, Int32, IntPtr, IntPtr) at System.Windows.Forms.UnsafeNativeMethods.CallWindowProc(IntPtr, IntPtr, Int32, IntPtr, IntPtr) at System.Windows.Forms.NativeWindow.DefWndProc(System.Windows.Forms.Message ByRef) at System.Windows.Forms.Control.WmMouseDown(System.Windows.Forms.Message ByRef, System.Windows.Forms.MouseButtons, Int32) at System.Windows.Forms.Control.WndProc(System.Windows.Forms.Message ByRef) at System.Windows.Forms.ComboBox.WndProc(System.Windows.Forms.Message ByRef) at LaunchBox.Controls.CheckBoxComboBox.PopupComboBox.WndProc(System.Windows.Forms.Message ByRef) at System.Windows.Forms.NativeWindow.Callback(IntPtr, Int32, IntPtr, IntPtr) at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG ByRef) at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG ByRef) at System.Windows.Forms.Application+ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr, Int32, Int32) at System.Windows.Forms.Application+ThreadContext.RunMessageLoopInner(Int32, System.Windows.Forms.ApplicationContext) at System.Windows.Forms.Application+ThreadContext.RunMessageLoop(Int32, System.Windows.Forms.ApplicationContext) at System.Windows.Forms.Form.ShowDialog(System.Windows.Forms.IWin32Window) at LaunchBox.Controls.SideBarControl.addButton_Click(System.Object, System.EventArgs) at System.Windows.Forms.ToolStripItem.RaiseEvent(System.Object, System.EventArgs) at System.Windows.Forms.ToolStripButton.OnClick(System.EventArgs) at System.Windows.Forms.ToolStripItem.HandleClick(System.EventArgs) at System.Windows.Forms.ToolStripItem.HandleMouseUp(System.Windows.Forms.MouseEventArgs) at System.Windows.Forms.ToolStrip.OnMouseUp(System.Windows.Forms.MouseEventArgs) at System.Windows.Forms.Control.WmMouseUp(System.Windows.Forms.Message ByRef, System.Windows.Forms.MouseButtons, Int32) at System.Windows.Forms.Control.WndProc(System.Windows.Forms.Message ByRef) at System.Windows.Forms.ToolStrip.WndProc(System.Windows.Forms.Message ByRef) at System.Windows.Forms.NativeWindow.Callback(IntPtr, Int32, IntPtr, IntPtr) at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG ByRef) at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG ByRef) at System.Windows.Forms.Application+ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr, Int32, Int32) at System.Windows.Forms.Application+ThreadContext.RunMessageLoopInner(Int32, System.Windows.Forms.ApplicationContext) at System.Windows.Forms.Application+ThreadContext.RunMessageLoop(Int32, System.Windows.Forms.ApplicationContext) at LaunchBox.Program.Main(System.String[]) From windows log B: Faulting application name: LaunchBox.exe, version: 5.5.0.0, time stamp: 0x562bee43 Faulting module name: comctl32.dll, version: 6.10.10240.16384, time stamp: 0x559f3ba2 Exception code: 0xc0000005 Fault offset: 0x00000000000e0c15 Faulting process id: 0x8528 Faulting application start time: 0x01d10f8f8227718e Faulting application path: D:\p\LaunchBox\LaunchBox.exe Faulting module path: C:\WINDOWS\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.10240.16384_none_f41f7b285750ef43\comctl32.dll Report Id: 6a8ef654-51c3-4fa1-9cf8-34211aafb984 Faulting package full name: Faulting package-relative application ID: From windows logs C: Fault bucket 120344654573, type 4 Event Name: APPCRASH Response: Not available Cab Id: 0 Problem signature: P1: LaunchBox.exe P2: 5.5.0.0 P3: 562bee43 P4: comctl32.dll P5: 6.10.10240.16384 P6: 559f3ba2 P7: c0000005 P8: 00000000000e0c15 P9: P10: Attached files: C:\T\U\WER8D75.tmp.WERInternalMetadata.xml These files may be available here: C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_LaunchBox.exe_c55fb64e3f4187ce0a8fecfd4ec30573189575_cd06b789_92d6a572 Analysis symbol: Rechecking for solution: 0 Report Id: 6a8ef654-51c3-4fa1-9cf8-34211aafb984 Report Status: 0 Hashed bucket: fd3e5aeac95b7273ec542f7470522ea0

[Jason Carr]

Thanks @haniobaid. This issue is due to putting so many values into those check box drop down lists. They don't handle it well, so I'm looking to completely revamp that dialog. It's also way to limited for the moment so I'm hoping to kill two birds with one stone.